snleee commented on a change in pull request #6118: URL: https://github.com/apache/incubator-pinot/pull/6118#discussion_r501864888
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/bloom/BloomFilterReaderFactory.java ########## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.segment.index.readers.bloom; + +import com.google.common.base.Preconditions; +import org.apache.pinot.core.segment.index.readers.BloomFilterReader; +import org.apache.pinot.core.segment.memory.PinotDataBuffer; + + +public class BloomFilterReaderFactory { + private BloomFilterReaderFactory() { + } + + public static BloomFilterReader getBloomFilterReader(PinotDataBuffer dataBuffer) { + int typeValue = dataBuffer.getInt(0); + int version = dataBuffer.getInt(4); + Preconditions.checkState(typeValue == 1 && version == 1); Review comment: Can we add some information for the failing state? We should add some information that the given bloom filter creator's type & value are not supported. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/bloom/BloomFilterReaderFactory.java ########## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.segment.index.readers.bloom; + +import com.google.common.base.Preconditions; +import org.apache.pinot.core.segment.index.readers.BloomFilterReader; +import org.apache.pinot.core.segment.memory.PinotDataBuffer; + + +public class BloomFilterReaderFactory { + private BloomFilterReaderFactory() { + } + + public static BloomFilterReader getBloomFilterReader(PinotDataBuffer dataBuffer) { + int typeValue = dataBuffer.getInt(0); Review comment: Can you make `0`, `4` as `static final` variable? e.g. `TYPE_VALUE_OFFSET`, `VERSION_OFFSET` ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/bloom/OffHeapGuavaBloomFilterReader.java ########## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.segment.index.readers.bloom; + +import com.google.common.base.Preconditions; +import com.google.common.primitives.Longs; +import org.apache.pinot.core.segment.index.readers.BloomFilterReader; +import org.apache.pinot.core.segment.memory.PinotDataBuffer; + + +/** + * Off-heap reader for guava bloom filter. + * <p>The behavior should be aligned with {@link com.google.common.hash.BloomFilter}. Review comment: So, our current implementation depends on `com.google.common.hash.BloomFilter` for bloom filter creation while we do have a custom offheap reader. This means that we need to adjust our offheap reader implementation if Guava changes the internal implementation details. I don't think that they will change the underlying convention often; however, we should also consider having our own custom bloom filter creator whose behavior aligns with this reader (basically mimic the existing guava) if the work is not too much. In that case, we won't need any external dependency and don't need to worry about aligning. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
