Jackie-Jiang commented on a change in pull request #6102:
URL: https://github.com/apache/incubator-pinot/pull/6102#discussion_r499935781
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##########
@@ -123,6 +124,15 @@ public void putValue(String fieldName, @Nullable Object
value) {
_fieldToValueMap.put(fieldName, value);
}
+ public PrimaryKey getPrimaryKey(List<String> primaryKeyColumns) {
+ Object[] values = new Object[primaryKeyColumns.size()];
+ int size = primaryKeyColumns.size();
+ for (int i = 0; i < size; i++) {
Review comment:
(nit)
```suggestion
int numPrimaryKeyColumns = primaryKeyColumns.size();
Object[] values = new Object[numPrimaryKeyColumns];
for (int i = 0; i < numPrimaryKeyColumns; i++) {
```
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/PrimaryKey.java
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.data.readers;
+
+import java.util.Arrays;
+
+
+/**
+ * The primary key of a record. Note that the value used in the primary key
must be single-value.
+ */
+public class PrimaryKey {
+ private final Object[] _values;
+
+ public PrimaryKey(Object[] fields) {
+ _values = fields;
Review comment:
(nit)
```suggestion
public PrimaryKey(Object[] values) {
_values = values;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
