[incubator-pinot] branch master updated: Making pushType non-mandatory (#6107)

[jackie]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 11ff74a  Making pushType non-mandatory (#6107)
11ff74a is described below

commit 11ff74a5af6cf2aaa7dd642775ef9553ee4ffe67
Author: icefury71 <chinmay.cere...@gmail.com>
AuthorDate: Mon Oct 5 16:35:27 2020 -0700

    Making pushType non-mandatory (#6107)
---
 .../src/main/java/org/apache/pinot/core/util/TableConfigUtils.java  | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java 
b/pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
index bc23bb9..d793f34 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
@@ -108,11 +108,7 @@ public final class TableConfigUtils {
 
     String segmentPushType = segmentsConfig.getSegmentPushType();
     // segmentPushType is not needed for Realtime table
-    if (tableConfig.getTableType() == TableType.OFFLINE) {
-      if (segmentPushType == null) {
-        throw new IllegalStateException(String.format("Table: %s, null push 
type", tableName));
-      }
-
+    if (tableConfig.getTableType() == TableType.OFFLINE && segmentPushType != 
null && !segmentPushType.isEmpty()) {
       if (!segmentPushType.equalsIgnoreCase("REFRESH") && 
!segmentPushType.equalsIgnoreCase("APPEND")) {
         throw new IllegalStateException(String.format("Table: %s, invalid push 
type: %s", tableName, segmentPushType));
       }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org