icefury71 commented on pull request #6107: URL: https://github.com/apache/incubator-pinot/pull/6107#issuecomment-703935277
> @mcvsubbu @jackjlli @snleee The mandatory check is just introduced in #6073, and might break the existing use cases without the push type configured (correct me if I was wrong @icefury71 ). I think there are offline use cases within LinkedIn without the push type, which will break. > We cannot directly change the default behavior to use `APPEND` if the push type is not mandatory for the existing use cases. Yes, this was mostly to conserve the existing use cases that don't explicitly specify a push type. Hence I removed the mandate. However, I did choose to add a default value (APPEND) since it will break the retention manager otherwise. @Jackie-Jiang lemme know if there are any implications of this assumption ? As @mcvsubbu mentioned, most of the code places kinda assume APPEND semantics. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
