Jackie-Jiang commented on a change in pull request #6096:
URL: https://github.com/apache/incubator-pinot/pull/6096#discussion_r499173365
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -99,6 +102,14 @@ public void setSchemaName(String schemaName) {
_schemaName = schemaName;
}
+ public void setPrimaryKeyColumns(List<String> primaryKeyColumns) {
+ _primaryKeyColumns = primaryKeyColumns;
+ }
+
+ public List<String> getPrimaryKeyColumns() {
Review comment:
(nit) put getter before setter for consistency
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -558,6 +576,11 @@ public SchemaBuilder addComplex(String name, DataType
dataType) {
return this;
}
+ public SchemaBuilder addPrimaryKeyColumns(List<String> primaryKeyColumns) {
Review comment:
```suggestion
public SchemaBuilder setPrimaryKeyColumns(List<String>
primaryKeyColumns) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
