vincentchenjl commented on pull request #6058:
URL: https://github.com/apache/incubator-pinot/pull/6058#issuecomment-699129769
> Also, I envision the new coordinator module to be able to access the sql
scripts without depending on `thirdeye-dashboard`.
I agree on this point. However, having all the tests in `thideye-dashboard`
and `create-schema.sql` in `thirdeye-pinot` cause `mvn install` to fail. There
are two ways going forward I can think of right now. One is to move
`create-schema.sql` to `thirdeye-dashboard`, and the other is to move the test
cases that require those schema back to `thirdeye-pinot`. Also, the last PR
already moved `persistence-local.yml` to `thirdeye-dashboard`, so we also need
to move it back if we want to go for second approach. Please let me know if
there is any other way to do it.
`[ERROR]
beforeMethod(org.apache.pinot.thirdeye.detection.alert.filter.ToAllRecipientsDetectionAlertFilterTest)
Time elapsed: 0.003 s <<< FAILURE!
java.lang.RuntimeException: java.io.FileNotFoundException:
file:/Users/jianchen/dev-projects/incubator-pinot/thirdeye/thirdeye-pinot/target/thirdeye-pinot-1.0.0-SNAPSHOT.jar!/schema/create-schema.sql
(No such file or directory)
at
org.apache.pinot.thirdeye.detection.alert.filter.ToAllRecipientsDetectionAlertFilterTest.beforeMethod(ToAllRecipientsDetectionAlertFilterTest.java:77)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
