adriancole opened a new pull request #6039: URL: https://github.com/apache/incubator-pinot/pull/6039
This is a work in progress towards #5977 Besides overall review of this sketch, this needs. [ ] how do we get a reference to the _helixResourceManager? [ ] do we need to block until Pinot Broker registers with the controller before installing the tables? [ ] can we can stop the controller from listening on a port until these tables are added? [ ] add test relative file paths can work [ ] add test multiple schemas install in parallel [ ] add test health check fails if a schema fails due to missing files, or inability to run addSchema or addTable. [ ] figure out where to document this [ ] determine if quickStart could or should use this ## Description This would allow one or more bootstrap config files that include one or more tables to add. ex given a file `etc/pinot-backendEntityView.conf` ``` pinot.service.role=ADD_TABLE pinot.addTable.schemaFile=./schemas/backendEntityView-schemaFile.json pinot.addTable.tableConfigFile=./schemas/backendEntityView-tableConfigFile.json ``` and a file `etc/pinot-rawServiceView.conf` ``` pinot.service.role=ADD_TABLE pinot.addTable.schemaFile=./schemas/rawServiceView-schemaFile.json pinot.addTable.tableConfigFile=./schemas/rawServiceView-tableConfigFile.json ``` you could pass the following to `StartServiceManager`: `-bootstrapConfigPaths etc/pinot-controller.conf etc/pinot-broker.conf etc/pinot-server.conf etc/pinot-backendEntityView.conf etc/pinot-backendEntityView.conf` What will happen in ideal case is the controller starts, the tables install, then the controller is listening. If we can't block the controller from listening until this is done, we can at least make sure health check is not ok. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? **No** Does this PR fix a zero-downtime upgrade introduced earlier? **No** Does this PR otherwise need attention when creating release notes? * [x] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes TODO ## Documentation TODO If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
