vincentchenjl commented on a change in pull request #6026:
URL: https://github.com/apache/incubator-pinot/pull/6026#discussion_r491239194



##########
File path: thirdeye/thirdeye-pinot/pom.xml
##########
@@ -361,52 +361,6 @@
 
   <build>
     <plugins>
-      <plugin>
-        <artifactId>maven-shade-plugin</artifactId>

Review comment:
       Per our discussion, we are going to publish shaded JAR and source JAR 
together. We should only remove this plugin once we have both JAR build. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to