[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6031: Handle the partitioning mismatch between table config and stream

[GitBox]

Jackie-Jiang commented on a change in pull request #6031:
URL: https://github.com/apache/incubator-pinot/pull/6031#discussion_r491191593



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -560,7 +566,8 @@ private void createNewSegmentZKMetadata(TableConfig 
tableConfig, PartitionLevelS
   }
 
   @Nullable
-  private SegmentPartitionMetadata 
getPartitionMetadataFromTableConfig(TableConfig tableConfig, int partitionId) {
+  private SegmentPartitionMetadata 
getPartitionMetadataFromTableConfig(TableConfig tableConfig, int numPartitions,

Review comment:
       Reverted this part to keep minimum change and keep the current behavior. 
Will handle this in the next PR which requires some perf testing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org