jihaozh commented on a change in pull request #5972:
URL: https://github.com/apache/incubator-pinot/pull/5972#discussion_r486511634
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyFilterWrapper.java
##########
@@ -81,21 +80,7 @@ public final DetectionPipelineResult run() throws Exception {
Set<Long> lastTimeStamps = new HashSet<>();
for (Map<String, Object> properties : this.nestedProperties) {
- DetectionConfigDTO nestedConfig = new DetectionConfigDTO();
-
- Preconditions.checkArgument(properties.containsKey(PROP_CLASS_NAME),
"Nested missing " + PROP_CLASS_NAME);
- HashMap<String, Object> nestedProp = new HashMap<>(properties);
- if (this.metricUrn != null){
- nestedProp.put(PROP_METRIC_URN, this.metricUrn);
- }
Review comment:
These lines were removed in this change, which can be an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
