mcvsubbu commented on a change in pull request #5873: URL: https://github.com/apache/incubator-pinot/pull/5873#discussion_r482452686
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/SchemaValidatorResult.java ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.data; + +/** + * The result class to provide the detailed mismatch information. + */ +public class SchemaValidatorResult { + private long _mismatchCount; + private StringBuilder _mismatchReason; + + public SchemaValidatorResult() { + _mismatchCount = 0; + _mismatchReason = new StringBuilder(); + } + + public boolean isMismatchDetected() { + return _mismatchCount != 0; + } + + private void incrementMismatchCount() { + _mismatchCount++; + } + + public String getMismatchReason() { + return _mismatchReason.toString(); + } + + private void addMismatchReason(String reason) { + if (_mismatchReason.length() > 0) { + _mismatchReason.append(" "); + } + _mismatchReason.append(reason); + } + + public void incrementMismatchCountWithMismatchReason(String reason) { Review comment: Suggestion: ```suggestion public void addMismatchReason(String reason) { ``` ########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/SchemaValidatorResult.java ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.data; + +/** + * The result class to provide the detailed mismatch information. + */ +public class SchemaValidatorResult { + private long _mismatchCount; + private StringBuilder _mismatchReason; + + public SchemaValidatorResult() { + _mismatchCount = 0; + _mismatchReason = new StringBuilder(); + } + + public boolean isMismatchDetected() { + return _mismatchCount != 0; + } + + private void incrementMismatchCount() { + _mismatchCount++; + } + + public String getMismatchReason() { + return _mismatchReason.toString(); + } + + private void addMismatchReason(String reason) { Review comment: ```suggestion private void addMismatchReasonInternal(String reason) { ``` ########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/SchemaValidator.java ########## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.data; + + +/** + * Validator to validate the schema between Pinot schema and input raw data schema + */ +public interface SchemaValidator { Review comment: Do u agree to this? Or, do you want to leave it as SchemaValidator? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
