adriancole opened a new issue #5950: URL: https://github.com/apache/incubator-pinot/issues/5950
Per #5850 we should have a /health endpoint for our service state. Composite services like ServiceManager should report their individual components, manifesting an aggregate healthy IFF all are healthy. This helps ensure traffic doesn't pass through when things aren't finished booting up, or if they crash after the fact. This was discussed in https://apache-pinot.slack.com/archives/CDRCA57FC/p1598498630061400 Make a composite health endpoint similar to this: ```java @GET @Produces(MediaType.APPLICATION_JSON) @Path("/instances") @ApiOperation(value = "Get Pinot Instances Status") @ApiResponses(value = {@ApiResponse(code = 200, message = "Instance Status"), @ApiResponse(code = 500, message = "Internal server error")}) public Map<String, PinotInstanceStatus> getPinotAllInstancesStatus() { Map<String, PinotInstanceStatus> results = new HashMap<>(); for (String instanceId : _pinotServiceManager.getRunningInstanceIds()) { results.put(instanceId, _pinotServiceManager.getInstanceStatus(instanceId)); } return results; } ``` and in doing so it similar to discovering and calling each of https://github.com/apache/incubator-pinot/pull/5846 main thing is to represent the composite of its health so you can know if the process should be in service or not. for example, i noticed one part of process fail in docker due to zip extraction maybe take too long no idea. still passes health check! that's bad as it fails other thing. cc @daniellavoie @fx19880617 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
