[incubator-pinot] branch master updated: [TE] Remove incessant DEBUG level logging (#5932)

[apucher]

This is an automated email from the ASF dual-hosted git repository.

apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 9cd46b1  [TE] Remove incessant DEBUG level logging (#5932)
9cd46b1 is described below

commit 9cd46b17533a62f1858e1902776c845ccdc63b76
Author: Suvodeep Pyne <suvodeep-p...@users.noreply.github.com>
AuthorDate: Wed Aug 26 17:25:05 2020 -0700

    [TE] Remove incessant DEBUG level logging (#5932)
    
    Removing a few debug level logging on a couple of classes which creates a 
lot of noise when running tests. These class instances go through a construct 
and destruct on every test and dumps the same logs over and over again.
    
    No backward incompatible changes.
---
 .../org/apache/pinot/thirdeye/datalayer/util/EntityMappingHolder.java  | 2 --
 .../java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java | 3 ---
 2 files changed, 5 deletions(-)

diff --git 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/EntityMappingHolder.java
 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/EntityMappingHolder.java
index 69a4290e..e2e7a9c 100644
--- 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/EntityMappingHolder.java
+++ 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/EntityMappingHolder.java
@@ -48,7 +48,6 @@ public class EntityMappingHolder {
   public void register(Connection connection, Class<? extends AbstractEntity> 
entityClass,
       String tableName) throws Exception {
     tableName = tableName.toLowerCase();
-    LOG.info("GENERATING MAPPING FOR TABLE: {}", tableName);
     DatabaseMetaData databaseMetaData = connection.getMetaData();
     String catalog = null;
     String schemaPattern = null;
@@ -92,7 +91,6 @@ public class EntityMappingHolder {
         if (success) {
           columnInfoMap.get(dbColumn).columnNameInEntity = entityColumn;
           columnInfoMap.get(dbColumn).field = field;
-          LOG.debug("Mapped {} to {}", dbColumn, entityColumn);
           columnMappingPerTable.get(tableName).put(dbColumn, entityColumn);
           break;
         }
diff --git 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java
 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java
index 6f4076c..0dfc009 100644
--- 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java
+++ 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java
@@ -123,8 +123,6 @@ public class SqlQueryBuilder {
       if (columnInfo.field != null
           && 
!AUTO_UPDATE_COLUMN_SET.contains(columnInfo.columnNameInDB.toLowerCase())) {
         Object val = columnInfo.field.get(entity);
-        LOG.debug("Setting value: {} for:{} sqlType:{}", val, 
columnInfo.columnNameInDB,
-            columnInfo.sqlType);
         if (val != null) {
           if (columnInfo.sqlType == Types.CLOB) {
             Clob clob = conn.createClob();
@@ -244,7 +242,6 @@ public class SqlQueryBuilder {
       String dbFieldName = paramEntry.getKey();
       ColumnInfo info = columnInfoMap.get(dbFieldName);
       prepareStatement.setObject(parameterIndex++, paramEntry.getValue(), 
info.sqlType);
-      LOG.debug("Setting value:{} for {}", paramEntry.getValue(), dbFieldName);
 
     }
     return prepareStatement;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org