renato2099 commented on pull request #5910: URL: https://github.com/apache/incubator-pinot/pull/5910#issuecomment-681089584
I was not sure which were the code paths that could use the json parsing, that is why I added it where it actually takes place. I moved it now to the createSegmentCommand as per your suggestion @Jackie-Jiang I decided to keep the test as I think it is good that we add tests for these commands ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
