fx19880617 commented on a change in pull request #5864:
URL: https://github.com/apache/incubator-pinot/pull/5864#discussion_r470792533
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -363,6 +363,7 @@ public void start()
LOGGER.info("Initializing server instance and registering state model
factory");
Utils.logVersions();
+ ControllerLeaderLocator.create(_helixManager);
Review comment:
Here we only hold a reference to helixManager
since we set ServerInstance::start as a addPreConnectCallback, then the
server will always start after helixManager connected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
