bkuang88 opened a new pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832
#5377 Description Currently, the DISTINCTCOUNTTHETASKETCH aggregation function does not support SET_DIFF operations. This pull-request addresses this gap. However, this commit does introduce a backwards-incompatible change. We are suggesting to change the syntax a bit to the following: DISTINCTCOUNTTHETASKETCH(col, 'nominalEntries=1234', 'predicate1', 'predicate2', 'SET_DIFF($1, $2)') We are introducing 3 "merging functions" into the Pinot aggregation function: 1. SET_UNION 2. SET_INTERSECT 3. SET_DIFF ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ x ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes This patch introduces a new syntax to the recently introduced DISTINCTCOUNTTHETASKETCH aggregation function. The syntax will also introduce the new SET_DIFF functionality between 2 theta sketches. The syntax will be as follows: DISTINCTCOUNTTHETASKETCH(col, 'nominalEntries=1024', 'colA=1', 'colB=2', 'SET_DIFF($1, $2)') ## Documentation If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
