cecilynie commented on a change in pull request #5823:
URL: https://github.com/apache/incubator-pinot/pull/5823#discussion_r467184126
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##########
@@ -156,30 +156,49 @@ public MergedAnomalyResultDTO getMergedAnomalyDetail(
* eg. payload
* <p/>
* { "feedbackType": "NOT_ANOMALY", "comment": "this
is not an anomaly" }
+ * @param propagate : a flag whether it should propagate the same
feedback value to the parent of this anomaly
+ * and all its siblings if they exist
*/
@POST
@Path(value = "anomaly-merged-result/feedback/{anomaly_merged_result_id}")
@ApiOperation("update anomaly merged result feedback")
- public void
updateAnomalyMergedResultFeedback(@PathParam("anomaly_merged_result_id") long
anomalyResultId,
+ public void updateAnomalyMergedResultFeedback(
+ @PathParam("anomaly_merged_result_id") long anomalyResultId,
+ @QueryParam("propagate") @DefaultValue("true") boolean propagate,
Review comment:
Hi Vincent, is the same API used for both anomalies page, root cause
page, application page and potentially alert page? Let's make sure the
consistent behavior, if users update the children anomalies' feedback from any
page above, it will always propagate the feedbacks to the parent anomaly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
