lgo opened a new pull request #5817: URL: https://github.com/apache/incubator-pinot/pull/5817
## Description Fixes #4752. Before, the Swagger initialization was only permitting HTTP schema for most applications and optionally the HTTPS schema which had to be configured. Now, Swagger will always list both schemas. By default, it picks the first schema (which will be HTTP) on the client. When a Swagger page is opened the swagger JS client will prefer the protcol the page is on, if it is listed as supported. This means the Swagger browser pages for Pinot will now work out-of-the-box for HTTPS-only setups. For this to work though, Swagger UI needs to be updated because the current version does not correctly select the scheme, which was addessed in https://github.com/swagger-api/swagger-js/pull/857. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [x] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes Removes the configuration option `controller.query.console.useHttps`. Support for HTTPS on the query console and Swagger is now automatic. ## Documentation N/A ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
