jasperjiaguo commented on a change in pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#discussion_r465926766
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ########## @@ -0,0 +1,519 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.recommender.io; + +import com.fasterxml.jackson.annotation.JsonAutoDetect; +import com.fasterxml.jackson.annotation.JsonIgnore; +import com.fasterxml.jackson.annotation.JsonSetter; +import com.fasterxml.jackson.annotation.Nulls; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.ObjectReader; +import java.io.IOException; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.pinot.controller.recommender.io.exceptions.InvalidInputException; +import org.apache.pinot.controller.recommender.io.metadata.ColumnMetaData; +import org.apache.pinot.controller.recommender.io.metadata.SchemaWithMetaData; +import org.apache.pinot.controller.recommender.rules.RulesToExecute; +import org.apache.pinot.controller.recommender.rules.io.params.BloomFilterRuleParams; +import org.apache.pinot.controller.recommender.rules.io.params.FlagQueryRuleParams; +import org.apache.pinot.controller.recommender.rules.io.params.InvertedSortedIndexJointRuleParams; +import org.apache.pinot.controller.recommender.rules.io.params.NoDictionaryOnHeapDictionaryJointRuleParams; +import org.apache.pinot.controller.recommender.rules.io.params.PartitionRuleParams; +import org.apache.pinot.controller.recommender.rules.utils.FixedLenBitset; +import org.apache.pinot.spi.data.DimensionFieldSpec; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.MetricFieldSpec; +import org.apache.pinot.spi.data.Schema; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static java.lang.Math.max; +import static org.apache.pinot.controller.recommender.rules.io.params.RecommenderConstants.*; + + +@JsonAutoDetect(fieldVisibility = JsonAutoDetect.Visibility.NONE) +public class InputManager { + private final Logger LOGGER = LoggerFactory.getLogger(InputManager.class); + + /******************************Deserialized from input json*********************************/ + // Basic input fields + public RulesToExecute _rulesToExecute = new RulesToExecute(); // dictates which rules to execute + public Schema _schema = new Schema(); + public SchemaWithMetaData _schemaWithMetaData = new SchemaWithMetaData(); + + public String _queryType = SQL; // SQL or PQL + public long _qps = DEFAULT_QPS; + public Map<String, Double> _queryWeightMap = new HashMap<>(); // {"queryString":"queryWeight"} + public String _tableType = OFFLINE; + public long _numMessagesPerSec = DEFAULT_NUM_MSG_PER_SEC; // messages per sec for kafka to consume + public long _numRecordsPerPush = DEFAULT_NUM_RECORDS_PER_PUSH; // records per push for offline part of a table + public long _latencySLA = DEFAULT_LATENCY_SLA; // latency sla in ms + public int _numKafkaPartitions = DEFAULT_NUM_KAFKA_PARTITIONS; + + // The parameters of rules + public PartitionRuleParams _partitionRuleParams = new PartitionRuleParams(); + public InvertedSortedIndexJointRuleParams _invertedSortedIndexJointRuleParams = + new InvertedSortedIndexJointRuleParams(); + public BloomFilterRuleParams _bloomFilterRuleParams = new BloomFilterRuleParams(); + public NoDictionaryOnHeapDictionaryJointRuleParams _noDictionaryOnHeapDictionaryJointRuleParams = + new NoDictionaryOnHeapDictionaryJointRuleParams(); + public FlagQueryRuleParams _flagQueryRuleParams = new FlagQueryRuleParams(); + + // For forward compatibility: 1. dev/sre to overwrite field(s) 2. incremental recommendation on existing/staging tables + public ConfigManager _overWrittenConfigs = new ConfigManager(); + + /******************************Ignored by deserializer****************************************/ Review comment: The fields following this line are pre-processed from the input and used as algorithm input only, so no need to serialize/deserialize them in any place ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
