Jackie-Jiang commented on a change in pull request #5786:
URL: https://github.com/apache/incubator-pinot/pull/5786#discussion_r464642766
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
##########
@@ -123,6 +123,8 @@ public static AggregationFunction
getAggregationFunction(FunctionContext functio
return new DistinctCountAggregationFunction(firstArgument);
case DISTINCTCOUNTBITMAP:
return new DistinctCountBitmapAggregationFunction(firstArgument);
+ case PARTITIONEDDISTINCTCOUNT:
Review comment:
Discussed offline. We should still keep no underscore within the
aggregation function type, and parser will remove the underscore from the input
function name to match the function type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
