guruguha commented on a change in pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#discussion_r460491469
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java ########## @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.util; + +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.google.common.collect.BiMap; +import java.io.IOException; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.Executor; +import org.apache.commons.httpclient.HttpConnectionManager; +import org.apache.pinot.common.exception.InvalidConfigException; +import org.apache.pinot.common.restlet.resources.SegmentStatus; +import org.apache.pinot.controller.api.resources.ServerSegmentMetadataReader; +import org.apache.pinot.controller.helix.core.PinotHelixResourceManager; +import org.apache.pinot.spi.utils.JsonUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class TableMetadataReader { + private static final Logger LOGGER = LoggerFactory.getLogger(TableMetadataReader.class); + + private final Executor executor; + private final HttpConnectionManager connectionManager; + private final PinotHelixResourceManager pinotHelixResourceManager; + + public TableMetadataReader(Executor executor, HttpConnectionManager connectionManager, + PinotHelixResourceManager helixResourceManager) { + this.executor = executor; + this.connectionManager = connectionManager; + this.pinotHelixResourceManager = helixResourceManager; + } + + public TableReloadStatus getReloadStatus(String tableNameWithType, Map<String, List<String>> serverToSegmentsMap, Review comment: It is outside in both methods as the "server side" classes don't have the resourceManager object. If it is moved to server side classes then the resourceManager object needs to be passed on - which might be overkill? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
