akshayrai commented on a change in pull request #5752: URL: https://github.com/apache/incubator-pinot/pull/5752#discussion_r460234402
########## File path: thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-comparison-range/component.js ########## @@ -48,23 +50,15 @@ export default Component.extend({ compareModeOptions: [ { groupName: 'Weekly', - options: [ 'wo1w', 'wo2w', 'wo3w', 'wo4w', 'mean4w', 'median4w', 'min4w', 'max4w' ] - }, - { - groupName: 'Hourly', - options: [ 'ho1h', 'ho2h', 'ho3h', 'ho6h', 'mean6h', 'median6h', 'min6h', 'max6h' ] - }, - { - groupName: 'Daily', - options: [ 'do1d', 'do2d', 'do3d', 'do4d', 'mean4d', 'median4d', 'min4d', 'max4d' ] - }, - { - groupName: 'Monthly', - options: [ 'mo1m', 'mo2m', 'mo3m', 'mo6m', 'mean6m', 'median6m', 'min6m', 'max6m' ] + options: [ 'wo1w', 'wo2w', 'wo3w', 'mean4w', 'median4w' ] }, { groupName: 'Algorithm', options: [ 'predicted', 'none' ] Review comment: Any clue on why we have a `none` type under Algorithm? shall we remove that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org