ianvkoeppe commented on a change in pull request #5745:
URL: https://github.com/apache/incubator-pinot/pull/5745#discussion_r460132216
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -122,19 +122,16 @@
public BaseBrokerRequestHandler(PinotConfiguration config, RoutingManager
routingManager,
AccessControlFactory accessControlFactory, QueryQuotaManager
queryQuotaManager, BrokerMetrics brokerMetrics,
- ZkHelixPropertyStore<ZNRecord> propertyStore) {
+ TableCache tableCache) {
_config = config;
_routingManager = routingManager;
_accessControlFactory = accessControlFactory;
_queryQuotaManager = queryQuotaManager;
_brokerMetrics = brokerMetrics;
+ _tableCache = tableCache;
_enableCaseInsensitive =
_config.getProperty(CommonConstants.Helix.ENABLE_CASE_INSENSITIVE_KEY, false);
- if (_enableCaseInsensitive) {
- _tableCache = new TableCache(propertyStore);
Review comment:
It's to avoid instantiating the cache in cases it isn't needed. Mayank
also called this out above...but it should be fine.
> Just want to call out every deployment will now read the table config for
the entire cluster, per broker. I think we do that for controller, and recently
added for server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
