snleee commented on a change in pull request #5728:
URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r459846427
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/SegmentSelectorFactory.java
##########
@@ -17,19 +17,25 @@
* under the License.
*/
package org.apache.pinot.broker.routing.segmentselector;
+import org.apache.helix.ZNRecord;
+import org.apache.helix.store.zk.ZkHelixPropertyStore;
import org.apache.pinot.spi.config.table.TableConfig;
import org.apache.pinot.spi.config.table.TableType;
+import org.apache.pinot.spi.utils.builder.TableNameBuilder;
public class SegmentSelectorFactory {
private SegmentSelectorFactory() {
}
- public static SegmentSelector getSegmentSelector(TableConfig tableConfig) {
+ public static SegmentSelector getSegmentSelector(TableConfig tableConfig,
+ ZkHelixPropertyStore<ZNRecord> propertyStore) {
+ String tableNameWithType =
+
TableNameBuilder.forType(tableConfig.getTableType()).tableNameWithType(tableConfig.getTableName());
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
