mayankshriv commented on a change in pull request #5734:
URL: https://github.com/apache/incubator-pinot/pull/5734#discussion_r459474270
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -450,18 +448,22 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
private void updateQuerySource(BrokerRequest brokerRequest) {
String tableName = brokerRequest.getQuerySource().getTableName();
// Check if table is in the format of [database_name].[table_name]
- String[] tableNameSplits = StringUtils.split(tableName, '.');
- if (tableNameSplits.length != 2) {
- return;
- }
+ String[] tableNameSplits = StringUtils.split(tableName, ".", 2);
Review comment:
Does the calcite parser not support getting columns names from
[table].[column] format? If so, we should just use that, instead of post
processing here? We have been adding small string manipulations per query
incrementally, and I fear it will add up to have performance significance soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
