Jackie-Jiang commented on pull request #5686: URL: https://github.com/apache/incubator-pinot/pull/5686#issuecomment-662766153
Discussed with @mayankshriv offline, the common logic has been extracted into `BaseCombineOperator`, and it is very hard to extract the per-thread logic because they are using different concurrency primitives. Added TODOs into the `GroupByCombineOperator` and `GroupByOrderByCombineOperator` to extend `BaseCombineOperator` for future cleanup ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
