[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5705: Add error message to broker response in case of broker send error

[GitBox]

Jackie-Jiang commented on a change in pull request #5705:
URL: https://github.com/apache/incubator-pinot/pull/5705#discussion_r456136984



##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java
##########
@@ -114,6 +116,12 @@ protected BrokerResponse processBrokerRequest(long 
requestId, BrokerRequest orig
     brokerResponse.setNumServersQueried(numServersQueried);
     brokerResponse.setNumServersResponded(numServersResponded);
 
+    Exception brokerRequestSendException = 
asyncQueryResponse.getBrokerRequestSendException();
+    if (brokerRequestSendException != null) {
+      String errorMsg = 
QueryException.getTruncatedStackTrace(brokerRequestSendException);
+      brokerResponse
+          .addToExceptions(new 
QueryProcessingException(QueryException.BROKER_REQUEST_SEND_ERROR_CODE, 
errorMsg));

Review comment:
       ```suggestion
         brokerResponse
             .addToExceptions(new 
QueryProcessingException(QueryException.BROKER_REQUEST_SEND_ERROR_CODE, 
brokerRequestSendException));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org