npawar commented on pull request #5706: URL: https://github.com/apache/incubator-pinot/pull/5706#issuecomment-659596321
> > > Recommend using exception to pass the failure message instead of passing in a logger for both simplicity and better control on the logging level > > > > > > The Schema validation code already was using a logger, and I was just trying to work around that. I'm not sure why it was done this way in Schema in the first place. I can change it to exception based throughout the Schema validation code path > > Yes, ideally we should also change Schema validation to exception based to prevent the unnecessary error log Changed the PR to use exceptions instead of logger in all of schema validations. @Jackie-Jiang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
