npawar commented on pull request #5642: URL: https://github.com/apache/incubator-pinot/pull/5642#issuecomment-657840758
I'm beginning to think we shouldn't do reserved keywords validation at all. Reasons being, 1. standard sql behavior allows columns to have such names. By making this change, we're essentially forever banning use of certain words from Pinot tables. Might make migration of datasets from one source into Pinot difficult 2. One of the motivations of doing this was reducing the occurrences of our open source users getting stuck on these words while querying. But this validation will move the problem from query time to ingestion time. It might not always be possible for users to change their source data names, so we would have to educate them on setting transform functions. I'll change this PR to include only the date time field spec validation @siddharthteotia @mcvsubbu ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
