mayankshriv commented on a change in pull request #5673:
URL: https://github.com/apache/incubator-pinot/pull/5673#discussion_r452322783
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java
##########
@@ -61,6 +63,33 @@ public String getString(int rowIndex, int columnIndex) {
}
}
+ public List<String> getAllColumns() {
+ List<String> columns = new ArrayList<>();
+ if (_columnNamesArray == null) {
+ return columns;
+ }
+
+ for (JsonNode column : _columnNamesArray) {
+ columns.add(column.textValue());
+ }
+
+ return columns;
+ }
+
+
+ public List<String> getAllColumnsDataTypes() {
+ List<String> columnDataTypes = new ArrayList<>();
+ if (_columnDataTypesArray == null) {
Review comment:
Would it be better to model ` private final JsonNode
_columnDataTypesArray;` as a Schema object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
