kishoreg commented on a change in pull request #5608:
URL: https://github.com/apache/incubator-pinot/pull/5608#discussion_r445771444
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartBrokerCommand.java
##########
@@ -120,7 +121,7 @@ public boolean execute()
}
}
- private Configuration getBrokerConf()
+ private Map<String, Object> getBrokerConf()
Review comment:
shouldn't this be returning pinotconfiguration?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
