fx19880617 commented on a change in pull request #5653:
URL: https://github.com/apache/incubator-pinot/pull/5653#discussion_r449732244
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -514,6 +522,30 @@ private void addForwardIndex(GenericRow row, int docId,
Map<String, Object> dict
numValuesInfo.updateMVEntry(dictIds.length);
}
+
+ // Update min/max value for columns
+ BaseMutableDictionary dictionary = _dictionaryMap.get(column);
+ if (dictionary != null) {
+ _minValueMap.put(column, dictionary.getMinVal());
Review comment:
Make sense, I will change to just store no-dictionary min/max values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
