mayankshriv commented on a change in pull request #5653:
URL: https://github.com/apache/incubator-pinot/pull/5653#discussion_r449028009
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -367,11 +366,33 @@ public SegmentPartitionConfig getSegmentPartitionConfig()
{
}
public long getMinTime() {
- return _minTime;
+ Long minTime = extractTimeValue(_minValueMap.get(_timeColumnName));
+ if (minTime != null) {
+ return minTime;
+ }
+ return Long.MAX_VALUE;
}
public long getMaxTime() {
Review comment:
Seems this is used only in `HLRealtimeSegmentDataManager`?
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -425,6 +449,37 @@ public boolean index(GenericRow row, @Nullable RowMetadata
rowMetadata) {
return canTakeMore;
}
+ private void updateMinMaxValue(GenericRow row) {
Review comment:
Can this be done inline during `index()` (inside `addForwardIndex`)?
Doing it separately may have several redundant operations, that may impact use
cases with high ingestion rate.
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RealtimeNoDictionaryTimeColumnClusterIntegrationTest.java
##########
@@ -0,0 +1,42 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.integration.tests;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.apache.commons.io.FileUtils;
+import org.apache.pinot.util.TestUtils;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+
+/**
+ * Extends RealtimeClusterIntegrationTest and configure time column to be a
non-dictionary column.
+ */
+public class RealtimeNoDictionaryTimeColumnClusterIntegrationTest extends
RealtimeClusterIntegrationTest {
Review comment:
Will this be run as a separate integration test (as in setup/teardown
the cluster)? If so, perhaps it can be merged into
`RealtimeClusterIntegrationTest` by choosing some of the columns as
`noDictionary`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
