mcvsubbu commented on a change in pull request #5336:
URL: https://github.com/apache/incubator-pinot/pull/5336#discussion_r448664817
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -268,21 +276,79 @@ public void addSegment(String segmentName, TableConfig
tableConfig, IndexLoading
}
public void downloadAndReplaceSegment(String segmentName,
LLCRealtimeSegmentZKMetadata llcSegmentMetadata,
- IndexLoadingConfig indexLoadingConfig) {
+ IndexLoadingConfig indexLoadingConfig, TableConfig tableConfig) {
final String uri = llcSegmentMetadata.getDownloadUrl();
+ if (uri != null && !uri.isEmpty()) {
Review comment:
check against uri not equal to `CommonConstants.Segments.SomeConstant`
that we define as `""`. The controller and server should use the same.
Also, uri can never be null, since we never write it as null for a completed
segments. You can remove that check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
