chenboat commented on a change in pull request #5639:
URL: https://github.com/apache/incubator-pinot/pull/5639#discussion_r448600944
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -355,8 +355,9 @@ void setIdealState(String realtimeTableName, IdealState
idealState) {
* This method moves the segment file from another location to its permanent
location.
* When splitCommit is enabled, segment file is uploaded to the
segmentLocation in the committingSegmentDescriptor,
* and we need to move the segment file to its permanent location before
committing the segment metadata.
+ * Return the permanent location of the segment if the commit succeeds.
*/
- public void commitSegmentFile(String realtimeTableName,
CommittingSegmentDescriptor committingSegmentDescriptor)
+ public String commitSegmentFile(String realtimeTableName,
CommittingSegmentDescriptor committingSegmentDescriptor)
Review comment:
done. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
