jackjlli commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-pinot/pull/5628#discussion_r446413542
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1796,16 +1796,16 @@ private boolean updateExistedSegment(String
tableNameWithType, String segmentNam
}
// Set all partitions to online so that they load the new segment data
- do {
- final IdealState idealState =
_helixAdmin.getResourceIdealState(_helixClusterName, tableNameWithType);
+ HelixHelper.updateIdealState(_helixZkManager, tableNameWithType,
idealState -> {
Review comment:
It is following the this protocol in `updateIdealState` method. You can
check the code here:
https://github.com/apache/incubator-pinot/blob/00fcb1d27f8daec48c1d87d46abfc8b60cfb32cf/pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelper.java#L120
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
