akshayrai commented on a change in pull request #5607:
URL: https://github.com/apache/incubator-pinot/pull/5607#discussion_r445194693
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
##########
@@ -30,17 +30,14 @@ import { getValueFromYaml } from
'thirdeye-frontend/utils/yaml-tools';
import { inject as service } from '@ember/service';
import { task } from 'ember-concurrency';
import floatToPercent from 'thirdeye-frontend/utils/float-to-percent';
-import { setUpTimeRangeOptions } from
'thirdeye-frontend/utils/manage-alert-utils';
import moment from 'moment';
import _ from 'lodash';
import config from 'thirdeye-frontend/config/environment';
const TABLE_DATE_FORMAT = 'MMM DD, hh:mm A'; // format for anomaly table
const TIME_PICKER_INCREMENT = 5; // tells date picker hours field how
granularly to display time
-const DEFAULT_ACTIVE_DURATION = '1m'; // setting this date range selection as
default (Last 24 Hours)
Review comment:
Are there any functional changes as part of this UI change? Will the
default display time window be the same as before (based on granularity)?
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
##########
@@ -1449,32 +1449,13 @@ export default Component.extend({
* @method onRangeSelection
* @param {Object} rangeOption - the user-selected time range to load
*/
- onRangeSelection(timeRangeOptions) {
- const {
- start,
- end,
- value: duration
- } = timeRangeOptions;
-
+ onRangeSelection(start, end) {
const startDate = moment(start).valueOf();
const endDate = moment(end).valueOf();
+
//Update the time range option selected
set(this, 'analysisRange', [startDate, endDate]);
set(this, 'displayRange', [startDate, endDate]);
- set(this, 'duration', duration);
- // This makes sure we don't fetch if the preview is collapsed
- if(get(this, 'showDetails') && get(this, 'dataIsCurrent')){
- // With a new date range, we should reset the state of time series and
anomalies for comparison
- if (get(this, 'isPreviewMode')) {
- this.setProperties({
- anomaliesOld: [],
- anomaliesOldSet: false,
- anomaliesCurrent: [],
- anomaliesCurrentSet: false
- });
- }
- this._fetchAnomalies();
- }
Review comment:
this is no longer required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
