siddharthteotia commented on a change in pull request #5605:
URL: https://github.com/apache/incubator-pinot/pull/5605#discussion_r445148299
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##########
@@ -486,69 +447,44 @@ private void setGroupByResults(BrokerResponseNative
brokerResponseNative, boolea
finalResultMaps[i] = finalResultMap;
}
- int aggregationNumsInFinalResult = 0;
- for (int i = 0; i < _numAggregationFunctions; i++) {
- if (aggregationFunctionsSelectStatus[i]) {
- aggregationNumsInFinalResult++;
- }
- }
-
- if (aggregationNumsInFinalResult > 0) {
Review comment:
Looks like this piece of code was redundant and that'w why you invoke
trimming on already computed finalResultMaps in the new code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
