daniellavoie commented on a change in pull request #5603:
URL: https://github.com/apache/incubator-pinot/pull/5603#discussion_r443802757
##########
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/filesystem/LocalPinotFSTest.java
##########
@@ -188,7 +188,7 @@ public void testFS()
localPinotFS.touch(nonExistingFile.toURI());
Assert.assertTrue(nonExistingFile.exists());
long currentTime = System.currentTimeMillis();
- Assert.assertTrue(localPinotFS.lastModified(nonExistingFile.toURI()) <
currentTime);
+ Assert.assertTrue(localPinotFS.lastModified(nonExistingFile.toURI()) <=
currentTime);
Review comment:
That's what I understood too. One or the other I don't really mind. I
just think that an equals value is still a valid assertion in that context and
would save us an irrelevant `Thread.sleep`. Just my 2 cents :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
