Jackie-Jiang commented on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-643885256
> Approving this since overall I am onboard with the change. My only request is to please try and make one more attempt at keeping separate names unless absolutely impossible. Even if the new name is ugly, it is fine IMHO. @siddharthteotia Appended `Context` to these classes to differentiate them from the thrift classes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
