mcvsubbu opened a new pull request #5542: URL: https://github.com/apache/incubator-pinot/pull/5542
Changed the interface exposed by streams to return StreamPartitionMsgOffset instead of long. Also changed the LLCRealtimeSegmentZKMetadat class to return String instead of long offsets, since it is stored as a String anyway. Luckily zk metadata does not generate java objects from json automatically (instead, parses the fields one by one via custom code). The segment endOffset can now be null in LLCRealtimeSegmentZKMetadata. For backward compatibility, we store Long.toSring(Long.MAX_VALUE) in zookeeper so that readers of the metadata do not get NPE if they are still running old version. We will remove this workaround after we release 0.5.0 The segment completion protocol for realtime LLC segment completion will continue to use both 'offset' and 'streamPartitionOffset' elements for one more release, and will move to use the latter completely in 0.6.0 Interfaces PartitionLevelConsumer and StreamMetadataProvider (marked STABLE) are now deprecating the calls that use long offsets. Instead, new calls have been added that use StreamPartitionMsgOffset. Kafka Plugins have been updated to use the new calls, but the old methods are preserved to make sure that any other Kafka implementations have time to move over. These calls will be removed in 0.6.0 The metric to show the highest offset consumed has disappeared. Testing done: Manually verified that LLCRealtimeClusterIntegrationTest completes segments correctly with old server and new controller as well as with new server and old controller, using command line starter for controller and server to start a component at a specific revision after 0.4.0 release. Issue #5359 ## Description Add a description of your PR here. A good description should include pointers to an issue or design document, etc. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text ## Documentation If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
