siddharthteotia commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438794993
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/FilterInfo.java ########## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import java.util.List; +import java.util.Objects; +import java.util.Set; +import org.apache.pinot.core.query.request.context.predicate.Predicate; + + +/** + * The {@code FilterInfo} class encapsulates the information of the filter in the query. Both WHERE clause and HAVING + * clause are modeled as a filter. + */ +public class FilterInfo { Review comment: Today execution engine is based on FilterQueryTree. So the wire request contains FilterQuery and FilterSubqueryMap. On the server, FilterPlanNode converts these into FilterQueryTree for each segment level execution. Why can't we continue to leverage FilterQueryTree? We should just create it once (since it is segment independent) and stash it away in QueryContext. It already encapsulates all the information that this class seems to provide. ########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ########## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.request.BrokerRequest; + + +/** + * The {@code QueryContext} class encapsulates all the query related information extracted from the wiring Object. Review comment: Is it correct to say that that this can be constructed on the server regardless of whether the wire object is BrokeRequest or PinotQuery. So we need to have 2 converters to be used upon request deserialization on the server side? - BrokerRequest to QueryRequest - PinotQuery to QueryRequest ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
