mcvsubbu commented on a change in pull request #5508:
URL: https://github.com/apache/incubator-pinot/pull/5508#discussion_r436891528
##########
File path: .travis/.travis_quickstart.sh
##########
@@ -69,7 +75,7 @@ sleep 30
for i in $(seq 1 200)
do
COUNT_STAR_RES=`curl -X POST --header 'Accept: application/json' -d
'{"sql":"select count(*) from meetupRsvp limit 1","trace":false}'
http://localhost:8000/query/sql | jq '.resultTable.rows[0][0]'`
- if [[ "${COUNT_STAR_RES}" =~ ^[0-9]+$ ]]; then
+ if [[ "${COUNT_STAR_RES}" =~ ^[0-9]+$ ]]; then
Review comment:
this is still not tolerant of failure in curl. The way to do this will
be something like
`x=$(curl ...); if [ $? -ne 0 ]; then continue; fi; echo "$x" | jq ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
