siddharthteotia edited a comment on pull request #5503: URL: https://github.com/apache/incubator-pinot/pull/5503#issuecomment-639876788
> If I understand the intention correctly, this PR want to let production environment to still use the `DEFAULT_VERSION`, but check in the classes of the `CURRENT_VERSION` and the tests for them. If that is the case, can we just add a separate constructor with the version info so that the tests can use that? The default constructor will create the writer with `DEFAULT_VERSION`. We don't really need to make it configurable because in production environment you never want to use `CURRENT_VERSION` before the version is verified. In order to move to the `CURRENT_VERSION`, you can simply change the default constructor to the `CURRENT_VERSION` - We want to use CURRENT_VERSION in production environment (use cases for text index are going to need the 8-byte chunk offset because of huge raw data). - CURRENT_VERSION is verified in production. We already have realtime segments that got completed and written with CURRENT_VERSION as of the currently deployed release in production. Has also been verified on our internal perf cluster. - However, for pbnj roll-out we need the flexibility temporarily to rollback the release if something **orthogonal to this** goes wrong. So while pbnj is being rolled out internally using implicit DEFAULT_VERSION, tables with text index are going to specifically enable this config since it has already been verified. Once the pbnj roll-out is complete, we can remove this Coming to changing the dotted notation, I haven't yet done the migration from IndexingConfig to FieldConfig. It is only being used for text. Going to migrate soon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
