[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5478: Add a new table config field for peer segment download.

[GitBox]

mcvsubbu commented on a change in pull request #5478:
URL: https://github.com/apache/incubator-pinot/pull/5478#discussion_r433971348



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java
##########
@@ -201,4 +207,16 @@ public static void validate(TableConfig tableConfig) {
       }
     }
   }
+
+  private static void validateValidationConfig(TableConfig tableConfig) {
+    SegmentsValidationAndRetentionConfig validationConfig = 
tableConfig.getValidationConfig();
+    if (validationConfig != null) {
+      String peerSegmentDownloadScheme = 
validationConfig.getPeerSegmentDownloadScheme();
+      if (peerSegmentDownloadScheme != null) {
+        if (!"http".equals(peerSegmentDownloadScheme) && 
!"https".equals(peerSegmentDownloadScheme)) {
+          throw new IllegalStateException("peerSegmentDownloadScheme: " + 
peerSegmentDownloadScheme + " is not http nor https" );

Review comment:
       ```suggestion
             throw new IllegalStateException("Invalid value '" + 
peerSegmentDownloadScheme + "' for peerSegmentDownloadScheme. Must be one of 
http nor https" );
   ```

##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java
##########
@@ -201,4 +207,16 @@ public static void validate(TableConfig tableConfig) {
       }
     }
   }
+
+  private static void validateValidationConfig(TableConfig tableConfig) {
+    SegmentsValidationAndRetentionConfig validationConfig = 
tableConfig.getValidationConfig();
+    if (validationConfig != null) {
+      String peerSegmentDownloadScheme = 
validationConfig.getPeerSegmentDownloadScheme();
+      if (peerSegmentDownloadScheme != null) {
+        if (!"http".equals(peerSegmentDownloadScheme) && 
!"https".equals(peerSegmentDownloadScheme)) {

Review comment:
       ```suggestion
           if (!"http".equalsIgnoreCase(peerSegmentDownloadScheme) && 
!"https".equalsIgnoreCase(peerSegmentDownloadScheme)) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org