fx19880617 commented on pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-634954131
> looks like this fix is a workaround to hide the actual problem in transform function? > > What would be the exception/error in transformfunction without this fix There is no error, in brokerRequest, it's converted to a string. E.g. if the literal is `2020-05-27`, without single quote, transform function will parse it to `2020` only. See here : TransformExpressionTree.compileToExpressionTree("2020-05-27 UTC") = '2020' TransformExpressionTree.compileToExpressionTree("'2020-05-27 UTC'") = '2020-05-27 UTC' ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org