xiaohui-sun commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r430861217
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskConstants.java
##########
@@ -26,15 +26,8 @@
DETECTION,
DETECTION_ALERT,
YAML_DETECTION_ONBOARD,
- ANOMALY_DETECTION,
- MERGE,
// TODO: deprecate ALERT task type
Review comment:
Remove //TODO
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/common/BaseThirdEyeApplication.java
##########
@@ -51,11 +46,9 @@
protected final Logger LOG = LoggerFactory.getLogger(this.getClass());
protected AnomalyFunctionManager anomalyFunctionDAO;
Review comment:
anomalyFunctionDAO is not used, including AnomalyFunctionManager.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##########
@@ -101,21 +99,18 @@
private MergedAnomalyResultManager anomalyMergedResultDAO;
private AlertConfigManager emailConfigurationDAO;
private MergedAnomalyResultManager mergedAnomalyResultDAO;
- private AutotuneConfigManager autotuneConfigDAO;
private DatasetConfigManager datasetConfigDAO;
private AnomalyFunctionFactory anomalyFunctionFactory;
private AlertFilterFactory alertFilterFactory;
Review comment:
Not used.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##########
@@ -160,14 +155,12 @@ public void run(ThirdEyeDashboardConfiguration config,
Environment env)
AnomalyFunctionFactory anomalyFunctionFactory = new
AnomalyFunctionFactory(config.getFunctionConfigPath());
Review comment:
AnomalyFunctionFactory is not used.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##########
@@ -101,21 +99,18 @@
private MergedAnomalyResultManager anomalyMergedResultDAO;
private AlertConfigManager emailConfigurationDAO;
private MergedAnomalyResultManager mergedAnomalyResultDAO;
- private AutotuneConfigManager autotuneConfigDAO;
private DatasetConfigManager datasetConfigDAO;
private AnomalyFunctionFactory anomalyFunctionFactory;
private AlertFilterFactory alertFilterFactory;
private LoadingCache<String, Long> collectionMaxDataTimeCache;
private static final DAORegistry DAO_REGISTRY = DAORegistry.getInstance();
- public AnomalyResource(AnomalyFunctionFactory anomalyFunctionFactory,
AlertFilterFactory alertFilterFactory,
- AlertFilterAutotuneFactory alertFilterAutotuneFactory) {
+ public AnomalyResource(AnomalyFunctionFactory anomalyFunctionFactory,
AlertFilterFactory alertFilterFactory) {
this.anomalyFunctionDAO = DAO_REGISTRY.getAnomalyFunctionDAO();
this.anomalyMergedResultDAO = DAO_REGISTRY.getMergedAnomalyResultDAO();
this.emailConfigurationDAO = DAO_REGISTRY.getAlertConfigDAO();
this.mergedAnomalyResultDAO = DAO_REGISTRY.getMergedAnomalyResultDAO();
- this.autotuneConfigDAO = DAO_REGISTRY.getAutotuneConfigDAO();
this.datasetConfigDAO = DAO_REGISTRY.getDatasetConfigDAO();
this.anomalyFunctionFactory = anomalyFunctionFactory;
Review comment:
This is not used.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/DatasetConfigBean.java
##########
@@ -93,10 +89,6 @@
private boolean requiresCompletenessCheck = false;
Review comment:
Not used.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskInfoFactory.java
##########
@@ -58,25 +54,9 @@ public static TaskInfo getTaskInfoFromTaskType(TaskType
taskType, String taskInf
case YAML_DETECTION_ONBOARD:
taskInfo = OBJECT_MAPPER.readValue(taskInfoString,
YamlOnboardingTaskInfo.class);
break;
- case ANOMALY_DETECTION:
- taskInfo = OBJECT_MAPPER.readValue(taskInfoString,
DetectionTaskInfo.class);
- break;
- case MERGE:
- LOG.error("TaskType MERGE not supported");
- break;
case MONITOR:
taskInfo = OBJECT_MAPPER.readValue(taskInfoString,
MonitorTaskInfo.class);
break;
- case ALERT:
- case ALERT2:
- taskInfo = OBJECT_MAPPER.readValue(taskInfoString,
AlertTaskInfo.class);
- break;
- case DATA_COMPLETENESS:
- taskInfo = OBJECT_MAPPER.readValue(taskInfoString,
DataCompletenessTaskInfo.class);
- break;
- case CLASSIFICATION:
- taskInfo = OBJECT_MAPPER.readValue(taskInfoString,
ClassificationTaskInfo.class);
- break;
default:
LOG.error("TaskType must be one of ANOMALY_DETECTION, MONITOR,
ALERT, ALERT2, DATA_COMPLETENESS, CLASSIFICATION");
Review comment:
Update error log accordingly.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##########
@@ -101,21 +99,18 @@
private MergedAnomalyResultManager anomalyMergedResultDAO;
private AlertConfigManager emailConfigurationDAO;
private MergedAnomalyResultManager mergedAnomalyResultDAO;
- private AutotuneConfigManager autotuneConfigDAO;
private DatasetConfigManager datasetConfigDAO;
private AnomalyFunctionFactory anomalyFunctionFactory;
private AlertFilterFactory alertFilterFactory;
private LoadingCache<String, Long> collectionMaxDataTimeCache;
private static final DAORegistry DAO_REGISTRY = DAORegistry.getInstance();
- public AnomalyResource(AnomalyFunctionFactory anomalyFunctionFactory,
AlertFilterFactory alertFilterFactory,
- AlertFilterAutotuneFactory alertFilterAutotuneFactory) {
+ public AnomalyResource(AnomalyFunctionFactory anomalyFunctionFactory,
AlertFilterFactory alertFilterFactory) {
this.anomalyFunctionDAO = DAO_REGISTRY.getAnomalyFunctionDAO();
Review comment:
This is not used.
##########
File path:
thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/datalayer/DaoTestUtils.java
##########
@@ -275,22 +273,6 @@ public static DetectionStatusDTO
getTestDetectionStatus(String dataset, long dat
return detectionStatusDTO;
}
- public static AutotuneConfigDTO getTestAutotuneConfig(long functionId, long
start, long end) {
- AutotuneConfigDTO autotuneConfigDTO = new AutotuneConfigDTO();
- autotuneConfigDTO.setFunctionId(functionId);
- autotuneConfigDTO.setStartTime(start);
- autotuneConfigDTO.setEndTime(end);
-
autotuneConfigDTO.setPerformanceEvaluationMethod(PerformanceEvaluationMethod.ANOMALY_PERCENTAGE);
- autotuneConfigDTO.setLastUpdateTimestamp(DateTime.now().getMillis());
- Map<String, String> config = new HashMap<>();
- config.put("ConfigKey", "ConfigValue");
- autotuneConfigDTO.setConfiguration(config);
- Map<String, Double> performance = new HashMap<>();
- performance.put(autotuneConfigDTO.getPerformanceEvaluationMethod().name(),
0.5);
- autotuneConfigDTO.setPerformance(performance);
- return autotuneConfigDTO;
- }
-
public static ClassificationConfigDTO getTestClassificationConfig(String
name, List<Long> mainFunctionIdList,
Review comment:
Not used.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##########
@@ -101,21 +99,18 @@
private MergedAnomalyResultManager anomalyMergedResultDAO;
private AlertConfigManager emailConfigurationDAO;
private MergedAnomalyResultManager mergedAnomalyResultDAO;
- private AutotuneConfigManager autotuneConfigDAO;
private DatasetConfigManager datasetConfigDAO;
private AnomalyFunctionFactory anomalyFunctionFactory;
private AlertFilterFactory alertFilterFactory;
private LoadingCache<String, Long> collectionMaxDataTimeCache;
private static final DAORegistry DAO_REGISTRY = DAORegistry.getInstance();
- public AnomalyResource(AnomalyFunctionFactory anomalyFunctionFactory,
AlertFilterFactory alertFilterFactory,
- AlertFilterAutotuneFactory alertFilterAutotuneFactory) {
+ public AnomalyResource(AnomalyFunctionFactory anomalyFunctionFactory,
AlertFilterFactory alertFilterFactory) {
this.anomalyFunctionDAO = DAO_REGISTRY.getAnomalyFunctionDAO();
this.anomalyMergedResultDAO = DAO_REGISTRY.getMergedAnomalyResultDAO();
Review comment:
What is the difference between anomalyMergedResultDAO and
mergedAnomalyResultDAO. Seems duplicate.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##########
@@ -160,14 +155,12 @@ public void run(ThirdEyeDashboardConfiguration config,
Environment env)
AnomalyFunctionFactory anomalyFunctionFactory = new
AnomalyFunctionFactory(config.getFunctionConfigPath());
AlertFilterFactory alertFilterFactory = new
AlertFilterFactory(config.getAlertFilterConfigPath());
Review comment:
AlertFilterFactory is not used.
All the classes under org.apache.pinot.thirdeye.detector.email.filter are
not used.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##########
@@ -181,7 +174,6 @@ public void run(ThirdEyeDashboardConfiguration config,
Environment env)
env.jersey().register(new AutoOnboardResource(config));
env.jersey().register(new ConfigResource(DAO_REGISTRY.getConfigDAO()));
env.jersey().register(new
CustomizedEventResource(DAO_REGISTRY.getEventDAO()));
- env.jersey().register(new TimeSeriesResource());
Review comment:
The above three lines are not used.
env.jersey().register(new DataResource(anomalyFunctionFactory,
alertFilterFactory)); env.jersey().register(new
DataResource(anomalyFunctionFactory, alertFilterFactory));
env.jersey().register(new AnomaliesResource(anomalyFunctionFactory,
alertFilterFactory));
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskConstants.java
##########
@@ -26,15 +26,8 @@
DETECTION,
DETECTION_ALERT,
YAML_DETECTION_ONBOARD,
- ANOMALY_DETECTION,
- MERGE,
// TODO: deprecate ALERT task type
- ALERT,
- ALERT2,
- MONITOR,
- DATA_COMPLETENESS,
- CLASSIFICATION,
- REPLAY
+ MONITOR
Review comment:
Add a simple description for each task type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
