fx19880617 commented on a change in pull request #5441:
URL: https://github.com/apache/incubator-pinot/pull/5441#discussion_r430280846
##########
File path: .gitignore
##########
@@ -44,4 +44,8 @@ yarn.lock
npm-debug.log*
yarn-debug.log*
-yarn-error.log*
\ No newline at end of file
+yarn-error.log*
+
+#quickstart files
+examples/
Review comment:
we have some directories named examples under `resources`, will this
make git ignoring them?
##########
File path: .gitignore
##########
@@ -44,4 +44,8 @@ yarn.lock
npm-debug.log*
yarn-debug.log*
-yarn-error.log*
\ No newline at end of file
+yarn-error.log*
+
+#quickstart files
+examples/
Review comment:
we have some directories named examples under `resources`, will this
make git ignoring them?
E.g.
```
./docker/images/pinot-superset/examples
./pinot-tools/src/main/resources/examples
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
