xiaohui-sun commented on a change in pull request #5184:
URL: https://github.com/apache/incubator-pinot/pull/5184#discussion_r427039218
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dataframe/util/DataFrameUtils.java
##########
@@ -493,14 +518,14 @@ public long apply(long... values) {
* Helper: Returns a pre-populated ThirdeyeRequestBuilder instance. Removes
invalid filter values.
*
* @param slice metric data slice
- * @param metric metric dto
* @param dataset dataset dto
* @param expressions metric expressions
- * @param metricDAO metric config DAO
* @return ThirdeyeRequestBuilder
* @throws ExecutionException
*/
- private static ThirdEyeRequest.ThirdEyeRequestBuilder
makeThirdEyeRequestBuilder(MetricSlice slice, MetricConfigDTO metric,
DatasetConfigDTO dataset, List<MetricExpression> expressions,
MetricConfigManager metricDAO) throws ExecutionException {
+ private static ThirdEyeRequest.ThirdEyeRequestBuilder
makeThirdEyeRequestBuilder(MetricSlice slice, DatasetConfigDTO dataset,
List<MetricExpression> expressions) throws ExecutionException {
+ validateTimeSeriesSize(dataset, slice.getStart(), slice.getEnd(),
slice.getGranularity());
Review comment:
@akshayrai Have you get a chance to address the comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
