mcvsubbu commented on a change in pull request #5345:
URL: https://github.com/apache/incubator-pinot/pull/5345#discussion_r422568460
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,13 @@
+## Upgrade Notes
+Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
+* [ ] Yes (Please label as **<code>backward-incompat</code>**)
+
+Does this PR fix a zero-downtime upgrade introduced earlier?
Review comment:
1. LinkedIn pulls weekly from open source and deploys into production.
LinkedIn (and others who may pull regularly from open source pinot) can get
some information of what may break the deployment (even if retro-fixed).
2. It is a good practice to have release notes that describe the upgrade
scenarios that may break. If we have good labels on PRs, whoever cuts the
release can compile the release notes easily.
3. It hopefully makes the reviewers think whether something may break
compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
